Skip to content

✨E2E: Added initial skeleton for testing MMUX services in E2E tests #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

✨E2E: Added initial skeleton for testing MMUX services in E2E tests #8301

merged 2 commits into from
Sep 4, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 4, 2025 •
edited
Loading

What do these changes do?

  • enhances the Makefile to allow for local testing of any deployment from your computer
  • adds initial pytest function that runs playwright against the deployment
  • currently just starts a new project with mmux service, waits for it to start, closes and deletes the project

Related issue/s

How to test

cd tests/e2e-playwright
make install-dev
make test-response-surface-modeling-anywhere

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 4, 2025
@sanderegg sanderegg self-assigned this Sep 4, 2025
@sanderegg sanderegg added e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work labels Sep 4, 2025
pcrespov
pcrespov approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg marked this pull request as ready for review September 4, 2025 07:30
GitHK
GitHK approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (3a35a33) to head (6b86dde).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8301      +/-   ##
==========================================
- Coverage   87.85%   84.35%   -3.50%     
==========================================
  Files        1940     1565     -375     
  Lines       75322    61289   -14033     
  Branches     1311      828     -483     
==========================================
- Hits        66177    51703   -14474     
- Misses       8750     9366     +616     
+ Partials      395      220     -175
Flag Coverage Δ *Carryforward flag
integrationtests 64.07% <ø> (+<0.01%) ⬆️
unittests 82.19% <ø> (-4.32%) ⬇️ Carriedforward from 3a35a33

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.14% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.77% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 91.04% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 91.92% <ø> (ø)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 75.10% <ø> (-12.93%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a35a33...6b86dde. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 6b86dde.

🟢 All jobs passed!

But CI Insights is watching 👀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit d235084 into ITISFoundation:master Sep 4, 2025
93 of 95 checks passed
@sanderegg sanderegg deleted the e2e/add-mmux-test branch September 4, 2025 10:58
@pcrespov pcrespov mentioned this pull request Sep 11, 2025
Closed
16 tasks
This was referenced Sep 18, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit

@alexpargon alexpargon Awaiting requested review from alexpargon

@JavierGOrdonnez JavierGOrdonnez Awaiting requested review from JavierGOrdonnez

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@sanderegg sanderegg

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

3 participants

@sanderegg @GitHK @pcrespov